Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-15774 : Update refresh tokens to chain (dev-mode) #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shantanu73
Copy link
Contributor

Description of change

Added code and unit tests for dev-mode

Manual QA steps

Risks

Rollback steps

  • revert this branch

1) Fixed pylint issue.
2) Modified changelog
tap_jira/http.py Outdated Show resolved Hide resolved
tap_jira/http.py Outdated Show resolved Hide resolved
tap_jira/http.py Show resolved Hide resolved
1) Fixed review comments related to _write_config() method.
2) Fixed unit test cases.
tests/unittests/test_dev_mode.py Outdated Show resolved Hide resolved
tests/unittests/test_error_handling.py Outdated Show resolved Hide resolved
tap_jira/http.py Outdated Show resolved Hide resolved
1) Fixed review comments.
2) Removed redundant variables and parameters.
1) Added fixtures for Client object in unittests.
2) Fixed review comments.
@JamesMarcogliese
Copy link

JamesMarcogliese commented Apr 4, 2023

Hello,

Is there anything else in the way of this merging? Does someone need a poke? This PR addresses the new 3LO rotating refresh tokens from Atlassian and it would be nice to start using this soon. I believe it's the only recourse for Jira cloud users as the basic auth option preforms a check that prohibits cloud connectivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants