Use importlib.resources to load default logging config file
#164
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows packaging Singer taps and targets as [_zipapps_](https://docs.python.org/3/library/zipapp.html), which can be executed directly by a Python interpreter without needing to install any dependencies: ```console $ python3 tap-surveymonkey.pyz --config config.json --discover > catalog.json ``` Otherwise errors like this are raised: ```console $ python3 target-jsonl.pyz --help Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/projects/target-jsonl/target-jsonl.pyz/__main__.py", line 2, in <module> File "/projects/target-jsonl/target-jsonl.pyz/target_jsonl.py", line 12, in <module> File "/projects/target-jsonl/target-jsonl.pyz/singer/__init__.py", line 1, in <module> File "/projects/target-jsonl/target-jsonl.pyz/singer/utils.py", line 13, in <module> File "/projects/target-jsonl/target-jsonl.pyz/singer/catalog.py", line 10, in <module> File "/projects/target-jsonl/target-jsonl.pyz/singer/logger.py", line 16, in get_logger File "/Users/personal/.pyenv/versions/3.11.7/lib/python3.11/logging/config.py", line 65, in fileConfig raise FileNotFoundError(f"{fname} doesn't exist") FileNotFoundError: /projects/target-jsonl/target-jsonl.pyz/singer/logging.conf doesn't exist ``` With this change: ```console $ python3 target-jsonl.pyz --help usage: target-jsonl.pyz [-h] [-c CONFIG] options: -h, --help show this help message and exit -c CONFIG, --config CONFIG Config file ```
edgarrmondragon
changed the title
importlib.resources default config fileimportlib.resources default logging config file
edgarrmondragon
changed the title
importlib.resources default logging config fileimportlib.resources to load default logging config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This allows packaging Singer taps and targets as zipapps, which can be executed directly by a Python interpreter without needing to install any dependencies:
$ python3 tap-surveymonkey.pyz --config config.json --discover > catalog.jsonOtherwise errors like this are raised:
With this change:
Manual QA steps
Risks
Rollback steps