Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get nested metadata #133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

judahrand
Copy link
Contributor

Description of change

This PR relies on #132

The aim of the Pull Request is to update the metadata.get_standard_metadata to provide metadata entries for nested fields. Without this feature if a user wants to disable a nested field they are able to but must manually add the metadata entry to the catalog. This would provide the entry by default allowing for my easy use of tools such as singer-discover to choose fields.

Manual QA steps

  • Check that you're happy with the testing and implementation

Risks

  • I have not supported the anyOf key in the schemas. I'm not sure how this would work anyway as having schemas with variable types doesn't seem terribly useful for data management purposes.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant