Loosen version requirements for pytz and jsonschema #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on this |
|
+1 these version pins can make life with singer-python difficult this branch is out of date. I would be willing to make a new PR if there is interest in reviewing and merging it? |
ericlebail
approved these changes
Apr 2, 2021
The updates to pytz have just been timezone db changes, which are important changes to bring in. It'd be great to be able to pin applications against specific versions, rather than have it enforced by singer-python
jarobe42
force-pushed
the
feature/allow-pytz-versions
branch
from
fa389e6
to
2819489
Compare
|
I've rebased this branch of master. Let me know if there's anything else that needs to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As discussed here in #123, a more permissive versioning is required to make singer-python compatible with Airflow.
Additionally, I personally have a project that requires some timezone updates present in pytz 2019.3. I've kept the allowed versions to a restricted range due to singer's preference for restrictive deps.
Manual QA steps
Risks
Rollback steps