Handle grapheme contains more than one code points #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,12 @@ export default function stringWidth(string, options = {}) { | |||
| continue; | |||
| } | |||
|
|
|||
| // For grapheme contains more than one code points | |||
There was a problem hiding this comment.
I don't think this is correct. Graphemes can have two code points and still take up a 1 width.
There was a problem hiding this comment.
Yea, I can see that from test, but not sure what's correct.
There was a problem hiding this comment.
[...grapheme].some(codePoint => eastAsianWidth(codePoint ) > 2)?
There was a problem hiding this comment.
I'm honestly not sure. The East Asian Width spec doesn't provide any guidance for that. From what I have seen from other implementations, all others use the first code point too.
|
We could maybe use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there are cases calculated wrong, but the grapheme width should not decided by the first code point.