Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JSONError #45

Merged
merged 3 commits into from
Nov 9, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 17 additions & 22 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,28 @@ import {codeFrameColumns} from '@babel/code-frame';
import indexToPosition from 'index-to-position';

export class JSONError extends Error {
name = 'JSONError';
fileName;
codeFrame;
rawCodeFrame;
#message;

constructor(message) {
super(message);

let _message = message instanceof Error
? message.message
: message;

Object.defineProperty(this, 'message', {
configurable: true,
enumerable: false,
get() {
return `${_message}${this.fileName ? ` in ${this.fileName}` : ''}${this.codeFrame ? `\n\n${this.codeFrame}\n` : ''}`;
},
set(value) {
_message = value;
},
});

this.name = 'JSONError';

if (Error.captureStackTrace) {
Error.captureStackTrace(this, JSONError);
}
// We cannot pass message to `super()`, otherwise the message getter and setter will be overridden.
sindresorhus marked this conversation as resolved.
Show resolved Hide resolved
// https://262.ecma-international.org/14.0/#sec-error-message
super();

this.#message = message;
Error.captureStackTrace?.(this, JSONError);
}

get message() {
const {fileName, codeFrame} = this;
return `${this.#message}${fileName ? ` in ${fileName}` : ''}${codeFrame ? `\n\n${codeFrame}\n` : ''}`;
}

set message(message) {
this.#message = message;
}
}

Expand Down