Remove unnecessary Dark Mode CSS #2155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mquevill
commented
May 2, 2024
Comment on lines
-168
to
-170
| .__fb-dark-mode { | ||
| --header-height: 0 !important; | ||
| } |
There was a problem hiding this comment.
In the newest round of Facebook's redesign, this actually needs to be removed, otherwise the bottom of the page is partially off the screen (See the button on the bottom left being cut off below)
There was a problem hiding this comment.
I literally just reported the cut off thing as an issue for dark mode, nice to see the code update to fix it is already ready already!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These CSS changes are no longer necessary. Most of them are not even selectors on the page any more. I tested these one at a time and couldn't see any changes visually and checked for the selectors too.