Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #197, informative error message for not supporting JDK 8 #198

Closed
wants to merge 1 commit into from

Conversation

eis
Copy link

@eis eis commented Feb 16, 2014

Uses maven enforcer rule to notify user that JDK 8 is not yet supported (See #197)

@Shusshu
Copy link
Contributor

Shusshu commented Feb 16, 2014

I haven't tried Java 8 but I would prefer someone to investigate the cause and fix the cause instead of blocking JDK 8 as a "fix" or "workaround"

@eis
Copy link
Author

eis commented Feb 16, 2014

So would I. The informative error message would be there until someone does that.

@Shusshu
Copy link
Contributor

Shusshu commented Feb 16, 2014

Maybe you can be that guy ? :)

@eis
Copy link
Author

eis commented Feb 16, 2014

It might be the general issue of javadoc tool in JDK 8 being more strict, see http://mail-archives.apache.org/mod_mbox/hadoop-common-issues/201311.mbox/%3CJIRA.12681661.1385586762252.48109.1385753855233@arcas%3E and http://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete. But ok, I'll add that as a comment to the original defect and will close this pull request.

@eis eis closed this Feb 16, 2014
@Shusshu
Copy link
Contributor

Shusshu commented Feb 16, 2014

Yup it's better as Java 8 isn't released yet, things could change and work on release day (at least we hope)

hborders pushed a commit to hborders/maven-android-sdk-deployer that referenced this pull request May 11, 2014
Another fix for Mac OS X Proguard bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants