Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix the links of faq & some other #4144

Merged
merged 11 commits into from May 14, 2024
Merged

web: fix the links of faq & some other #4144

merged 11 commits into from May 14, 2024

Conversation

MSarmadQadeer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented May 7, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@epoberezkin
@MSarmadQadeer
You can retrigger this bot by commenting recheck in this Pull Request

@Narasimha-sc
Copy link
Collaborator

duplicate of #4124 but with a bit different approach?

@MSarmadQadeer
Copy link
Collaborator Author

Fixed.
I have implemented a fix that checks whether the page URL contains the page path. If it doesn't, I append the path to the relative URL within that specific page by replacing the initial './' with the page path.

@MSarmadQadeer
Copy link
Collaborator Author

MSarmadQadeer commented May 14, 2024

links are working fine on my end
please review and merge this PR

@epoberezkin epoberezkin merged commit bd8c8b5 into master May 14, 2024
6 of 8 checks passed
@epoberezkin epoberezkin deleted the sq/web-links branch May 14, 2024 18:59
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants