core: api to differentiate contacts and conversations #4111

spaced4ndy · 2024-04-30T11:05:27Z

No description provided.

src/Simplex/Chat.hs

src/Simplex/Chat/Controller.hs

src/Simplex/Chat/Migrations/M20240430_conversation_deleted.hs

src/Simplex/Chat.hs

spaced4ndy · 2024-04-30T16:42:32Z

src/Simplex/Chat.hs

@@ -1009,22 +1009,41 @@ processChatCommand' vr = \case
        liftIO $ updateNoteFolderUnreadChat db user nf unreadChat
      ok user
    _ -> pure $ chatCmdError (Just user) "not supported"
-  APIDeleteChat (ChatRef cType chatId) notify -> withUser $ \user@User {userId} -> case cType of
+  APIDeleteChat cRef@(ChatRef cType chatId) chatDeleteMode -> withUser $ \user@User {userId} -> case cType of


for CDMEntity and CDMMessages UI would differentiate on response based on call params - update in model instead of deleting

spaced4ndy · 2024-04-30T16:46:00Z

src/Simplex/Chat/Store/Messages.hs

@@ -315,7 +315,7 @@ updateChatTs db User {userId} chatDirection chatTs = case toChatInfo chatDirecti
  DirectChat Contact {contactId} ->
    DB.execute
      db
-      "UPDATE contacts SET chat_ts = ? WHERE user_id = ? AND contact_id = ?"
+      "UPDATE contacts SET chat_ts = ?, chat_deleted = 0 WHERE user_id = ? AND contact_id = ?"


on new chat items UI would "manually" update contacts with chatDeleted set to False. May be a bit hacky but it seems a normal assumption to do from UI view point and less hassle than correctly propagate contact update from db operations to all responses in backend. This is somewhat similar in logic to chat "popping" to top on new chat items being only UI logic

spaced4ndy added 3 commits April 30, 2024 15:05

core: api to differentiate contacts and conversations

6405807

refactor

d118958

comment

0c59558

spaced4ndy commented Apr 30, 2024

View reviewed changes

src/Simplex/Chat.hs Outdated Show resolved Hide resolved

spaced4ndy marked this pull request as ready for review April 30, 2024 11:08

spaced4ndy requested a review from epoberezkin as a code owner April 30, 2024 11:08