Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification led for new message #4077

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

psuzn
Copy link

@psuzn psuzn commented Apr 24, 2024

Fixes #4029

@psuzn psuzn requested a review from epoberezkin as a code owner April 24, 2024 06:24
Copy link

github-actions bot commented Apr 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@psuzn
Copy link
Author

psuzn commented Apr 24, 2024

I have read the CLA Document and I hereby sign the CLA

shumvgolove added a commit to simplex-chat/cla that referenced this pull request Apr 24, 2024
@epoberezkin
Copy link
Member

Thank you!

It is cool, but it will raise objections from some users as something that can compromise privacy - so there should be an option in Notification settings, something like "Show light" (and we can set default to "on" for the new users and "off" for the existing users).

@avently

@summoner001
Copy link
Contributor

summoner001 commented Apr 25, 2024

@epoberezkin

Couldn't it be possible to set the LED color per profile like in k9 email?

And per profile enable/disable the notification led.

Or should I open a separate issue for this?

@epoberezkin
Copy link
Member

we don't set most privacy settings per profile, so no need to complicate it - the MVP to release it would be a global in-app setting that would apply to all profiles, because then it won't require any changes in the core - it just requires updating native preferences and adding a simple toggle in the UI.

@psuzn
Copy link
Author

psuzn commented Apr 29, 2024

Screenshot 2024-04-29 at 19 13 03 Screenshot 2024-04-29 at 19 25 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants