core: inactive connections/members #4009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaced4ndy
commented
Apr 10, 2024
Comment on lines
+4340
to
+4344
| processConnQCONT connEntity conn | ||
| lastSharedMsgId <- withStore' $ \db -> getLastItemSharedMsgId db m | ||
| forM_ lastSharedMsgId $ \lastMsgId -> do | ||
| let conn' = conn {inactive = False} :: Connection | ||
| void $ sendDirectMemberMessage conn' (XGrpMsgSkipped lastMsgId) groupId |
There was a problem hiding this comment.
processConnQCONT could return updated connection conn'
spaced4ndy
commented
Apr 10, 2024
Comment on lines
+4589
to
+4593
| processConnQCONT :: ConnectionEntity -> Connection -> CM () | ||
| processConnQCONT connEntity conn = | ||
| when (connInactive conn) $ do | ||
| withStore' $ \db -> setConnectionInactive db user conn False | ||
| toView $ CRConnectionInactive connEntity False |
There was a problem hiding this comment.
TODO could also reset on MSG and RCVD
spaced4ndy
commented
Apr 10, 2024
| @@ -4331,11 +4336,17 @@ processAgentMessageConn vr user@User {userId} corrId agentConnId agentMessage = | |||
| OK -> | |||
| -- [async agent commands] continuation on receiving OK | |||
| when (corrId /= "") $ withCompletedCommand conn agentMsg $ \_cmdData -> pure () | |||
| QCONT -> do | |||
| processConnQCONT connEntity conn | |||
| lastSharedMsgId <- withStore' $ \db -> getLastItemSharedMsgId db m | |||
There was a problem hiding this comment.
- for super peer it may be better to instead search via
msg_deliveriestable, to account for forwarded group messages (seeforwardMsg_)- may have to additionally store original shared msg id (currently shared_msg_id is for the forwarded message itself)
- or populate
group_snd_item_statuses? - store additional data?
spaced4ndy
commented
Apr 10, 2024
spaced4ndy
commented
Apr 10, 2024
| SELECT chat_item_id | ||
| FROM group_snd_item_statuses | ||
| WHERE group_member_id = ? | ||
| AND (group_snd_item_status LIKE 'snd_sent%' OR group_snd_item_status LIKE 'snd_rcvd%') |
There was a problem hiding this comment.
could store "tags" to avoid LIKE
spaced4ndy
commented
Apr 11, 2024
Comment on lines
+5945
to
+5948
| xGrpMsgSkipped :: GroupInfo -> GroupMember -> SharedMsgId -> RcvMessage -> UTCTime -> CM () | ||
| xGrpMsgSkipped _gInfo _m _sharedMsgId _msg _brokerTs = do | ||
| -- TODO can request delivery starting with _sharedMsgId here | ||
| pure () |
There was a problem hiding this comment.
originally had a new type of group event chat item created here, but removed it as there's already integrity error item created so it seems unnecessary. Maybe should add it back, with it saying "member continued delivery for you"
spaced4ndy
commented
Apr 11, 2024
| @@ -6470,7 +6500,7 @@ memberSendAction :: ChatMsgEvent e -> [GroupMember] -> GroupMember -> Maybe Memb | |||
| memberSendAction chatMsgEvent members m@GroupMember {invitedByGroupMemberId} = case memberConn m of | |||
| Nothing -> pendingOrForwarded | |||
| Just conn@Connection {connStatus} | |||
| | connDisabled conn || connStatus == ConnDeleted -> Nothing | |||
| | connDisabled conn || connInactive conn || connStatus == ConnDeleted -> Nothing | |||
There was a problem hiding this comment.
may apply to contact connections as well, decided against it and only track info for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.