Create list using list comprehension #644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug/pyjwt dependency (simple-salesforce#610) * Update setup.py Update pyjwt dependency * Update setup.py include cryptography for requirement for pyjwt * Update setup.py include pyjwt[crypto] in install requirements * Update setup.py remove [crypto] from pyjwt[crypto] in install_requires as causes travis-ci failure to build * remove extra leading space --------- Co-authored-by: JonWobken <49450080+jon-wobken@users.noreply.github.com>
…s_hook (simple-salesforce#634) * Bug/pyjwt dependency (simple-salesforce#610) * Update setup.py Update pyjwt dependency * Update setup.py include cryptography for requirement for pyjwt * Update setup.py include pyjwt[crypto] in install requirements * Update setup.py remove [crypto] from pyjwt[crypto] in install_requires as causes travis-ci failure to build * Updated __getattr__ function to create SFType object with object_pairs_hook as input Right now let us say that the user creates a SFType object using __getattr__ function which is present in the class SalesForce. If the SalesForce object is initiated using object_pairs_hook being dict or print. In that case the user would want the response from SFType to be same as that object as well. So I have added object_pairs_hook in the SFType object which is being called in the __getattr__ function of the SalesForce Class * Updated __getattr__ function to create SFType object with object_pairs_hook Right now let us say that the user creates a SFType object using getattr function which is present in the class SalesForce. If the SalesForce object is initiated using object_pairs_hook being dict or print. In that case the user would want the response from SFType to be same as that object as well. So I have added object_pairs_hook in the SFType object which is being called in the getattr function of the SalesForce Class * removed whitespaces * pylint --------- Co-authored-by: JonWobken <49450080+jon-wobken@users.noreply.github.com>
* Bug/pyjwt dependency (simple-salesforce#610) * Update setup.py Update pyjwt dependency * Update setup.py include cryptography for requirement for pyjwt * Update setup.py include pyjwt[crypto] in install requirements * Update setup.py remove [crypto] from pyjwt[crypto] in install_requires as causes travis-ci failure to build * Fix indent in setup.py --------- Co-authored-by: JonWobken <49450080+jon-wobken@users.noreply.github.com>
* Bug/pyjwt dependency (simple-salesforce#610) * Update setup.py Update pyjwt dependency * Update setup.py include cryptography for requirement for pyjwt * Update setup.py include pyjwt[crypto] in install requirements * Update setup.py remove [crypto] from pyjwt[crypto] in install_requires as causes travis-ci failure to build * fix: use unescaped username for JWT claim JWT Bearer Flow needs JWT claim sub containg unescaped username Connected App Login has been fixed by simple-salesforce#604 --------- Co-authored-by: JonWobken <49450080+jon-wobken@users.noreply.github.com>
instead of creating an empty list and appending to it.
ericbn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of creating an empty list and appending to it.