Add auto-completion for SObject names #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would cost one API call per instance of the Salesforce class. |
That's an excellent point. I guess that makes this idea undesirable, unless an optional parameter were added to the constructor, something like a boolean called |
ericbn
reviewed
Dec 7, 2022
| in self.describe()['sobjects']] | ||
| except: # pylint: disable=bare-except | ||
| self._sobject_names = [] | ||
|
|
There was a problem hiding this comment.
Maybe this code could be moved inside the __dir__ function so it does not run in production code. Also not sure the bare except is a good idea -- could be at least except Exception:.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salesforce objects retrieve SObject names during initialization and append them to the normal elements returned by dir, allowing for auto-complete of SObject names found in the Salesforce instance. (Sadly, not all IDEs support auto-completion using dir.)