Update apexecute to handle GET requests #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If data is None don't call json.dumps
courtneyod
changed the title
|
With a recent update, our SF instance start complaining and we find the error narrow to this point. We have implemented a workaround but I would prefer have a clean solution. I see that there is other attempt to fix this (see #324 for example). Can I provide help to fix this and have it merged and released ? It seems the build issue is mainly a line too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
apexecuteso it can handle GET requests as well. It now conditionally callsjson.dumps(data)if data is notNone. Also added test coverage forapexecute.