Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to listing views of subsite-filtered sections #490

Merged
merged 1 commit into from Sep 1, 2023
Merged

Switch to listing views of subsite-filtered sections #490

merged 1 commit into from Sep 1, 2023

Conversation

micschk
Copy link
Contributor

@micschk micschk commented Sep 27, 2022 •
edited

Fixes #489
Fixes #404
Fixes #461

@GuySartorelli GuySartorelli changed the base branch from 2 to 2.8 September 1, 2023 02:57
GuySartorelli
GuySartorelli approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and works well locally, thank you! I've retargetted this to the 2.8 branch so we can release it as a patch, since it's fixing a bug.

@GuySartorelli GuySartorelli merged commit 4049f7a into silverstripe:2.8 Sep 1, 2023
This was referenced Sep 1, 2023
Open
Open
Open
@emteknetnz emteknetnz mentioned this pull request Sep 6, 2023
Closed
@emteknetnz
Copy link
Member

This one looks to have caused a regression - I've opened a PR to revert #539

@GuySartorelli
Copy link
Member

@micschk Sorry we had to revert this PR - there's more information in #538. If you'd like to take another go at this I'd be happy to review it, just @ me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@micschk @emteknetnz @GuySartorelli