Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pull-request #538

Closed
emteknetnz opened this issue Sep 6, 2023 · 1 comment
Closed

Revert pull-request #538

emteknetnz opened this issue Sep 6, 2023 · 1 comment
Assignees
@GuySartorelli

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 6, 2023 •
edited

#490 was merged, though likely the green CI build was over a year old at time of merging.

The merge commit was red https://github.com/silverstripe/silverstripe-subsites/actions/runs/6044881143/job/16404112238 so the PR shouldn't have been merged in its current state. I tried rerunning to broken behat builds a couple of times though they remained red.

Checking out the commit on the 2.8 directly before the merge conflict fixed the behat test on my local

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli