Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error pages do not account for SubsiteDomain #438

Open
NightJar opened this issue Jul 25, 2019 · 0 comments
Open

Error pages do not account for SubsiteDomain #438

NightJar opened this issue Jul 25, 2019 · 0 comments

Comments

@NightJar
Copy link
Contributor

When I create an error page on a subsite and perform a dev/build, a static file is cached to the assets folder.
This file seems correct, excepting the base tag contains the main site base url, not swapping the domain out for that which the Subsite is set to listen for.

Recreate:

  1. Have a project on a domain e.g. localhost
  2. create a subsite on this project.
  3. set a domain for that subsite e.g. subsite.localhost
  4. create an errorpage on that subsite
  5. publish that error page
  6. perform dev/build
  7. see the contents of e.g. public/assets/error-404-subsite.localhost.html contains the base url of http://subsite/ instead of http://subsite.localhost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants