Running dev/build via CLI throws [Notice]: Undefined index: HTTP_HOST #437

ChrissiQ · 2019-07-15T21:15:02Z

Because $_SERVER variables are not set in the CLI, the dev/build command thows a notice:

[1;31mERROR [Notice]: Undefined index: HTTP_HOST
IN GET dev/build
�[0m�[31mLine 189 in [path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php

�[0mSource
======
  180:     /**
  181:      * Retrieves domain name with wildcards substituted with actual values
  182:      *
  183:      * @todo Refactor domains into separate wildcards / primary domains
  184:      *
  185:      * @return string
  186:      */
  187:     public function getSubstitutedDomain()
  188:     {
* 189:         $currentHost = $_SERVER['HTTP_HOST'];
  190: 
  191:         // If there are wildcards in the primary domain (not recommended), make some
  192:         // educated guesses about what to replace them with:
  193:         $domain = preg_replace('/\.\*$/', ".{$currentHost}", $this->Domain);
  194: 
  195:         // Default to "subsite." prefix for first wildcard

Trace
=====
Monolog\ErrorHandler->handleError(8, Undefined index: HTTP_HOST, [path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php, 189, Array)
SubsiteDomain.php:189

SilverStripe\Subsites\Model\SubsiteDomain->getSubstitutedDomain()
ViewableData.php:133

SilverStripe\View\ViewableData->__get(SubstitutedDomain)
Subsite.php:874

SilverStripe\Subsites\Model\Subsite->domain()
ErrorPageSubsite.php:47

SilverStripe\Subsites\Extensions\ErrorPageSubsite->updateErrorFilename(error-404.html, 404, , , , , )
Extensible.php:468

SilverStripe\View\ViewableData->extend(updateErrorFilename, error-404.html, 404)
ErrorPage.php:399

SilverStripe\ErrorPage\ErrorPage::get_error_filename(404, SilverStripe\ErrorPage\ErrorPage)
ErrorPage.php:411

SilverStripe\ErrorPage\ErrorPage->getErrorFilename()
ErrorPage.php:268

SilverStripe\ErrorPage\ErrorPage->hasStaticPage()
ErrorPage.php:167

SilverStripe\ErrorPage\ErrorPage->requireDefaultRecordFixture(Array)
ErrorPage.php:140

SilverStripe\ErrorPage\ErrorPage->requireDefaultRecords()
DatabaseAdmin.php:382

SilverStripe\ORM\DatabaseAdmin->doBuild(, 1)
DatabaseAdmin.php:150

SilverStripe\ORM\DatabaseAdmin->build()
DatabaseAdmin.php:122

SilverStripe\ORM\DatabaseAdmin->index(SilverStripe\Control\HTTPRequest)
RequestHandler.php:323

SilverStripe\Control\RequestHandler->handleAction(SilverStripe\Control\HTTPRequest, index)
Controller.php:284

SilverStripe\Control\Controller->handleAction(SilverStripe\Control\HTTPRequest, index)
RequestHandler.php:202

SilverStripe\Control\RequestHandler->handleRequest(SilverStripe\Control\HTTPRequest)
Controller.php:212

SilverStripe\Control\Controller->handleRequest(SilverStripe\Control\HTTPRequest)
DevBuildController.php:24

SilverStripe\Dev\DevBuildController->build(SilverStripe\Control\HTTPRequest)
RequestHandler.php:323

SilverStripe\Control\RequestHandler->handleAction(SilverStripe\Control\HTTPRequest, build)
Controller.php:284

SilverStripe\Control\Controller->handleAction(SilverStripe\Control\HTTPRequest, build)
RequestHandler.php:202

SilverStripe\Control\RequestHandler->handleRequest(SilverStripe\Control\HTTPRequest)
Controller.php:212

SilverStripe\Control\Controller->handleRequest(SilverStripe\Control\HTTPRequest)
RequestHandler.php:226

SilverStripe\Control\RequestHandler->handleRequest(SilverStripe\Control\HTTPRequest)
Controller.php:212

SilverStripe\Control\Controller->handleRequest(SilverStripe\Control\HTTPRequest)
Director.php:360

SilverStripe\Control\Director->SilverStripe\Control\{closure}(SilverStripe\Control\HTTPRequest)
VersionedHTTPMiddleware.php:41

SilverStripe\Versioned\VersionedHTTPMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
InitStateMiddleware.php:44

SilverStripe\Subsites\Middleware\InitStateMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
DebugBarMiddleware.php:17

LeKoala\DebugBar\Middleware\DebugBarMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
ExecMetricMiddleware.php:20

SilverStripe\Control\Middleware\ExecMetricMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
ConfirmationMiddleware.php:246

SilverStripe\Control\Middleware\ConfirmationMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
ConfirmationMiddleware.php:246

SilverStripe\Control\Middleware\ConfirmationMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
BasicAuthMiddleware.php:68

SilverStripe\Security\BasicAuthMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
AuthenticationMiddleware.php:61

SilverStripe\Security\AuthenticationMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
CanonicalURLMiddleware.php:190

SilverStripe\Control\Middleware\CanonicalURLMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
HTTPCacheControlMiddleware.php:42

SilverStripe\Control\Middleware\HTTPCacheControlMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
ChangeDetectionMiddleware.php:27

SilverStripe\Control\Middleware\ChangeDetectionMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
FlushMiddleware.php:27

SilverStripe\Control\Middleware\FlushMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
RequestProcessor.php:66

SilverStripe\Control\RequestProcessor->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
SessionMiddleware.php:20

SilverStripe\Control\Middleware\SessionMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
AllowedHostsMiddleware.php:60

SilverStripe\Control\Middleware\AllowedHostsMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
TrustedProxyMiddleware.php:176

SilverStripe\Control\Middleware\TrustedProxyMiddleware->process(SilverStripe\Control\HTTPRequest, Closure)
HTTPMiddlewareAware.php:62

SilverStripe\Control\Director->SilverStripe\Control\Middleware\{closure}(SilverStripe\Control\HTTPRequest)
HTTPMiddlewareAware.php:65

SilverStripe\Control\Director->callMiddleware(SilverStripe\Control\HTTPRequest, Closure)
Director.php:369

SilverStripe\Control\Director->handleRequest(SilverStripe\Control\HTTPRequest)
HTTPApplication.php:117

SilverStripe\Control\HTTPApplication::SilverStripe\Control\{closure}(SilverStripe\Control\HTTPRequest)

call_user_func(Closure, SilverStripe\Control\HTTPRequest)
HTTPApplication.php:136

SilverStripe\Control\HTTPApplication->SilverStripe\Control\{closure}(SilverStripe\Control\HTTPRequest)
HTTPMiddlewareAware.php:65

SilverStripe\Control\HTTPApplication->callMiddleware(SilverStripe\Control\HTTPRequest, Closure)
HTTPApplication.php:137

SilverStripe\Control\HTTPApplication->execute(SilverStripe\Control\HTTPRequest, Closure, 1)
HTTPApplication.php:118

SilverStripe\Control\HTTPApplication->handle(SilverStripe\Control\HTTPRequest)
cli-script.php:22

[2019-07-15 13:42:08] error-log.NOTICE: E_NOTICE: Undefined index: HTTP_HOST {"code":8,"message":"Undefined index: HTTP_HOST","file":"[path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php","line":189} []
PHP Notice:  Undefined index: HTTP_HOST in [path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php on line 189
[2019-07-15 13:42:08] error-log.NOTICE: E_NOTICE: Undefined index: HTTP_HOST {"code":8,"message":"Undefined index: HTTP_HOST","file":"[path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php","line":189} []
PHP Notice:  Undefined index: HTTP_HOST in [path]/vendor/silverstripe/subsites/src/Model/SubsiteDomain.php on line 189

The text was updated successfully, but these errors were encountered:

robbieaverill · 2019-07-15T21:30:43Z

We may be able to refactor this to use an injectable HTTPRequest, and also build in a silent return if no request is set. Something like this:

- $currentHost = $_SERVER['HTTP_HOST'];
+ if (!Injector::inst()->has(HTTPRequest::class)) {
+     return '';
+ }
+ /** @var HTTPRequest $request */
+ $request = Injector::inst()->get(HTTPRequest::class);
+ $currentHost = $request->getHost();

Untested

robbieaverill · 2019-07-16T13:03:01Z

I've put this as impact/medium because I've never experienced this before, so it's probably harder to come across (do you have steps to reproduce?).

I'll note that some other server variables are set by HTTPRequestBuilder during the app startup, but HTTP_HOST doesn't appear to be one of them. I think we should replace its use in this code to avoid it the null pointer exception.

NightJar · 2019-07-17T02:36:30Z

As to steps to recreate, I'm going to hazard a guess that this is because an error page has been created for a subsite, which I believe isn't automatically created when adding a subsite which is likely why we've not come across it.
These write a static cache to disk on flush, which means the page must render - with correct links.
I get similar errors all the time because my webserver setup runs a different user to my login, although mine are permission errors, it seems the trace to get to that point is familiar to me.

Have a project with subsites installed
Create a subsite
Create an error page for that subsite
- possibly programmatically e.g. requireDefaultRecords or a BuildTask
dev/build from the CLI.

Are you able to confirm please @ChrissiQ ?

Leapfrognz · 2019-07-24T02:04:08Z

I also get the same issue. SS4 CWP 2.3

robbieaverill · 2019-07-24T09:22:28Z

Would one of you mind providing steps to reproduce on a clean install please?

NightJar · 2019-07-25T22:16:21Z

Let's go on a journey

    "require": {
        "php": ">=5.6.0",
        "silverstripe/recipe-plugin": "^1.2",
        "silverstripe/recipe-cms": "4.4.x-dev",
        "silverstripe-themes/simple": "~3.2.0",
        "silverstripe/subsites": "2.3.x-dev"
    },

I have set up a subsite. By default, it has either no pages or a single page (this admittedly was an existing install for addressing another subsites issue - but I've reset to heads and composer update before proceeding)

I set up an error page. I have chosen 400, please ignore that this is inconsistent with my choice of Title (although this shouldn't matter; neither the code nor the title).

dev/build has completed successfully.

BUT

This has uncovered another bug, in that the error page has generated with the wrong domain.

My project is subfix.localhost
My subsite is configured to be sfix.localhost (note the filename in the breadcrumbs).

Interestingly, when I do remove the domain from my Subsite definition (in the CMS), no page is generated at all. This is OK though.

So, how is my environment configured?

[vagrant@archlinux subfix]$ grep URL ../.env 
SS_BASE_URL="http://localhost:8080/"

Note though that the domain used in the static page generation is not matching this environment definition 🤔

Oh... whoops!

[vagrant@archlinux subfix]$ php -i | grep error
display_errors => Off => Off

Ah, but

[vagrant@archlinux subfix]$ grep -rin error_reporting vendor/silverstripe/framework/
vendor/silverstripe/framework/src/Core/CoreKernel.php:455:            error_reporting(E_ALL & ~(E_DEPRECATED | E_STRICT | E_NOTICE));
vendor/silverstripe/framework/src/Core/CoreKernel.php:458:            error_reporting(E_ALL | E_STRICT);

The second line is for sites not in live mode, and my environment is set to dev :)

[vagrant@archlinux subfix]$ grep -i environment_type ../.env 
SS_ENVIRONMENT_TYPE="dev"

So, a breakpoint in getSubstituteDomain shows that when building, this code is never called.

So, where are we so far?

The environment is sane: PHP 7.1, modules are up to date with development head, and error reporting is enabled.
The SilverStripe environment is in dev mode, and SS_BASE_URL is set to http://localhost/.
I have created a project subfix, with a Subsite with the SubsiteDomain set to sfix.localhost - these work as expected. I have created an error page on that subsite, and published it.
dev/build works for me. Static error page caches are created, but they use the wrong domain... and getSubstituteDomain is never called.

NightJar · 2019-07-26T03:44:44Z

Got it. Thanks @Leapfrognz for providing more context (via Slack)

A subsite where Default site is true

This is the only criterion.

Reproduction:

Install a base project
require subsites
dev/build
load CMS
open Subsites admin
click create subsite
tick Default site
click Create
dev/build from CLI.

robbieaverill · 2019-07-26T07:56:53Z

PR at #440

ScopeyNZ · 2019-07-29T22:37:08Z

#440 is merged.

NZTA · 2019-09-18T04:43:16Z

After Director::host(); back, http_host issue is coming back. However, robbie's fix
isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : 'localhost';
is working ..
Can you please help why this is happened?

robbieaverill · 2019-09-18T16:53:25Z

@NZTA can you please clarify what you mean? Is the fix working or not working for you?

NZTA · 2019-09-18T21:59:44Z

@NZTA can you please clarify what you mean? Is the fix working or not working for you?

This is not working after changing to Director::host();.

robbieaverill · 2019-09-18T22:07:38Z

Can you clarify the problem you’re having? Are you seeing undefined index errors, does your dev/build break, does the subsite functionality break..?

satrun77 · 2019-09-25T21:47:45Z

Hi @robbieaverill

The fix in #440 merged into version 2.0 but does not exist from version 2.1

2.0: https://github.com/silverstripe/silverstripe-subsites/blob/2.0/src/Model/SubsiteDomain.php#L188
2.1: https://github.com/silverstripe/silverstripe-subsites/blob/2.1/src/Model/SubsiteDomain.php#L188

robbieaverill · 2019-09-25T22:01:45Z

@satrun77 thanks for letting me know. I've merged all the branches up. You can use a dev branch for now until a new version is tagged in each release line, e.g. 2.1.x-dev or 2.2.x-dev in your composer constraint for the subsites module.

robbyahn · 2019-09-25T22:39:11Z

Thanks, @satrun77.
After running dev/build, it showed that undefined index errors under the subsite domain.

NightJar · 2019-09-25T23:20:26Z

@robbyahn please confirm:

You have updated the composer dependency from a constraint (e.g. "silverstripe/subsites": "^2") to a dev version (e.g. "silverstripe/subsites": "2.2.x-dev")
You have run a composer update
Composer has updated silverstripe/subsites to 38b356c
👀 You are still seeing the same error

robbyahn · 2019-09-26T21:39:06Z

@robbyahn please confirm:

You have updated the composer dependency from a constraint (e.g. "silverstripe/subsites": "^2") to a dev version (e.g. "silverstripe/subsites": "2.2.x-dev")

You have run a composer update

Composer has updated silverstripe/subsites to 38b356c

👀 You are still seeing the same error

It was happened in cwp 2.3.
Thanks, after merging, it is working good.

NightJar · 2019-09-26T22:41:48Z

Thanks for reporting back :)
These adjustments will be released into CWP with the next quarterly release.

robbieaverill added affects/v4 change/patch complexity/medium impact/medium type/bug labels Jul 16, 2019

robbieaverill self-assigned this Jul 26, 2019

robbieaverill mentioned this issue Jul 26, 2019

FIX Prevent undefined index notice when trying to determine HTTP_HOST during dev/build #440

Merged

robbieaverill removed their assignment Jul 26, 2019

ScopeyNZ closed this as completed Jul 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running dev/build via CLI throws [Notice]: Undefined index: HTTP_HOST #437

Running dev/build via CLI throws [Notice]: Undefined index: HTTP_HOST #437

ChrissiQ commented Jul 15, 2019

robbieaverill commented Jul 15, 2019

robbieaverill commented Jul 16, 2019

NightJar commented Jul 17, 2019

Leapfrognz commented Jul 24, 2019

robbieaverill commented Jul 24, 2019

NightJar commented Jul 25, 2019 •

edited

NightJar commented Jul 26, 2019 •

edited

robbieaverill commented Jul 26, 2019

ScopeyNZ commented Jul 29, 2019

NZTA commented Sep 18, 2019 •

edited

robbieaverill commented Sep 18, 2019

NZTA commented Sep 18, 2019 •

edited by ScopeyNZ

robbieaverill commented Sep 18, 2019

satrun77 commented Sep 25, 2019

robbieaverill commented Sep 25, 2019

robbyahn commented Sep 25, 2019

NightJar commented Sep 25, 2019

robbyahn commented Sep 26, 2019 •

edited

NightJar commented Sep 26, 2019

Running dev/build via CLI throws [Notice]: Undefined index: HTTP_HOST #437

Running dev/build via CLI throws [Notice]: Undefined index: HTTP_HOST #437

Comments

ChrissiQ commented Jul 15, 2019

robbieaverill commented Jul 15, 2019

robbieaverill commented Jul 16, 2019

NightJar commented Jul 17, 2019

Leapfrognz commented Jul 24, 2019

robbieaverill commented Jul 24, 2019

NightJar commented Jul 25, 2019 • edited

Let's go on a journey

So, where are we so far?

NightJar commented Jul 26, 2019 • edited

robbieaverill commented Jul 26, 2019

ScopeyNZ commented Jul 29, 2019

NZTA commented Sep 18, 2019 • edited

robbieaverill commented Sep 18, 2019

NZTA commented Sep 18, 2019 • edited by ScopeyNZ

robbieaverill commented Sep 18, 2019

satrun77 commented Sep 25, 2019

robbieaverill commented Sep 25, 2019

robbyahn commented Sep 25, 2019

NightJar commented Sep 25, 2019

robbyahn commented Sep 26, 2019 • edited

NightJar commented Sep 26, 2019

NightJar commented Jul 25, 2019 •

edited

NightJar commented Jul 26, 2019 •

edited

NZTA commented Sep 18, 2019 •

edited

NZTA commented Sep 18, 2019 •

edited by ScopeyNZ

robbyahn commented Sep 26, 2019 •

edited