Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX many_many through should allow subclasses #11230

Merged
merged 1 commit into from May 13, 2024
Merged

FIX many_many through should allow subclasses #11230

merged 1 commit into from May 13, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli
FIX many_many through should allow subclasses
fcfbb75 
```php
class HomePage extends Page
{
    private static $many_many = [
        'HeroImages' => [
            'through' => PageImageLink::class,
            'from' => 'Page',
            'to' => 'Image',
        ]
    ];

}
```

```php
class PageImageLink extends DataObject
{
    private static $has_one = [
        'Page' => SiteTree::class,
        'Image' => Image::class,
    ];
}

This fails because the linking object's relation class doesn't exactly match the owner. Sharing the linking objects across various entries in the ancestry should be a supported use case.
@GuySartorelli GuySartorelli mentioned this pull request May 10, 2024
Closed
emteknetnz
emteknetnz approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works good

@emteknetnz emteknetnz merged commit 50a0018 into silverstripe:5.2 May 13, 2024
30 checks passed
@emteknetnz emteknetnz deleted the pulls/5.2/many-many-through-subclass branch May 13, 2024 02:15
xbandradio
xbandradio reviewed May 16, 2024
View reviewed changes
Copy link

@xbandradio xbandradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fcfbb75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbandradio xbandradio xbandradio left review comments

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuySartorelli @emteknetnz @xbandradio