ENH Use allowed view button for readonly GridField #11228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/use-allowed-view-button
branch
2 times, most recently
from
6ff91dc
to
e610492
Compare
GuySartorelli
force-pushed
the
pulls/5/use-allowed-view-button
branch
from
e610492
to
a35f3c0
Compare
GuySartorelli
force-pushed
the
pulls/5/use-allowed-view-button
branch
from
a35f3c0
to
4bb1a4e
Compare
GuySartorelli
force-pushed
the
pulls/5/use-allowed-view-button
branch
from
4bb1a4e
to
5dd1efd
Compare
emteknetnz
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of allowed readonly components is configurable. Developers might replace the
GridFieldViewButtonwith their own implementation for a specific instance of aGridField. In that case, we want to make sure the correct component is used instead of the baseGridFieldViewButtonclass.Issue