ENH Update AttributesHTML to output alt attribute even if it's empty #11217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-rainville
force-pushed
the
pulls/5/alt-attribute-html
branch
2 times, most recently
from
03be15d
to
3a703eb
Compare
maxime-rainville
force-pushed
the
pulls/5/alt-attribute-html
branch
from
3a703eb
to
d42fa9e
Compare
There was a problem hiding this comment.
The original AttributesHTML was only covered by indirect tests of classes using the trait. I decided to add an explicit test.
emteknetnz
requested changes
May 14, 2024
| class AttributesHTMLTest extends SapphireTest | ||
| { | ||
|
|
||
| public function singleAttributeProvider(): array |
There was a problem hiding this comment.
Suggested change
| public function singleAttributeProvider(): array | |
| public function provideGetAttribute(): array |
Follow the naming conventions for data providers
| ]; | ||
| } | ||
|
|
||
| /** @dataProvider singleAttributeProvider */ |
There was a problem hiding this comment.
Suggested change
| /** @dataProvider singleAttributeProvider */ | |
| /** | |
| * @dataProvider provideTestAttribute | |
| */ |
| /** @dataProvider singleAttributeProvider */ | ||
| public function testGetAttribute($name, $value, $message): void | ||
| { | ||
| $dummy = new AttributesHTMLTest\DummyAttributesHTML(); |
There was a problem hiding this comment.
Suggested change
| $dummy = new AttributesHTMLTest\DummyAttributesHTML(); | |
| $dummy = DummyAttributesHTML(); |
Import this class. Make this change throughout this file
| { | ||
| $dummy = new AttributesHTMLTest\DummyAttributesHTML(); | ||
|
|
||
| $dummy->setAttribute('emptystring', ''); |
There was a problem hiding this comment.
Use a data provider for this instead
There was a problem hiding this comment.
getAttributesHTML takes all the attributes and combined them into one string.
I'm not trying to test individuals scenarios here. I'm trying to test the scenario where you combined all these attributes together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeHTMLwant to suppress attributes with falsy values.When rendering Images and the
altattribute contains a blank string, the attribute should be rendered anyway.Arguably this should be on
ImageManipulationinstead, but it seems like an sensible exception to have across the board. I haven't decided yet.Issue