API Don't publicly expose extension hook methods #10515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/5/protected-extension-hooks
branch
from
54e7a78
to
4454d8f
Compare
GuySartorelli
force-pushed
the
pulls/5/protected-extension-hooks
branch
from
4454d8f
to
55fda28
Compare
|
This is something that definitely requires a level of automated code scanning, it's simply too error prone to do this manually Will create the PRs using https://github.com/emteknetnz/extension-protector/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension hook methods should be protected - this should be best practices for CMS 5 now that it is a possibility as it reduces the public API surface extensions introduce.
Parent Issue