Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update writing style guide #494

Closed

Conversation

emteknetnz
Copy link
Member

Issue #302

@michalkleiner
Copy link
Contributor

I know it's a draft but since I came across it I've left a few suggestions.

@emteknetnz emteknetnz marked this pull request as ready for review May 14, 2024 05:55
@emteknetnz emteknetnz force-pushed the pulls/5/writing-style branch 2 times, most recently from fa7d736 to fbc6f59 Compare May 14, 2024 05:58
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Outdated Show resolved Hide resolved
en/10_Contributing/02_Documentation.md Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should target 5.2

@emteknetnz emteknetnz changed the base branch from 5 to 5.2 May 15, 2024 04:37
@emteknetnz
Copy link
Member Author

I messed up my rebase from 5.2 somehow, so just opened a new PR with a cherry-pick of the latest commit on this PR - #512

@emteknetnz emteknetnz closed this May 15, 2024
@GuySartorelli GuySartorelli deleted the pulls/5/writing-style branch May 15, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants