New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Update writing style guide #494
Closed
emteknetnz
wants to merge
5
commits into
silverstripe:5.2
from
creative-commoners:pulls/5/writing-style
Closed
DOC Update writing style guide #494
emteknetnz
wants to merge
5
commits into
silverstripe:5.2
from
creative-commoners:pulls/5/writing-style
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Apr 11, 2024
I know it's a draft but since I came across it I've left a few suggestions. |
emteknetnz
force-pushed
the
pulls/5/writing-style
branch
2 times, most recently
from
May 14, 2024 05:58
fa7d736
to
fbc6f59
Compare
GuySartorelli
requested changes
May 14, 2024
emteknetnz
force-pushed
the
pulls/5/writing-style
branch
from
May 15, 2024 03:19
fbc6f59
to
5baed78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but should target 5.2
emteknetnz
force-pushed
the
pulls/5/writing-style
branch
from
May 15, 2024 04:36
5baed78
to
59eab82
Compare
I messed up my rebase from 5.2 somehow, so just opened a new PR with a cherry-pick of the latest commit on this PR - #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #302