Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to support "in-schema" tool setup? #1092

Open
nmoroze opened this issue Jul 19, 2022 · 0 comments
Open

Do we want to support "in-schema" tool setup? #1092

nmoroze opened this issue Jul 19, 2022 · 0 comments

Comments

@nmoroze
Copy link
Contributor

nmoroze commented Jul 19, 2022

A small detail that came up when I was debugging error failures in #1091: do you think we should support configuring tools fully within the schema?

For example, we have a test that sets up some imaginary tools like:

...
    chip.set('tool', 'foo', 'exe', 'foo')
    chip.set('tool', 'bar', 'exe', 'foo')
    chip.set('tool', 'baz', 'exe', 'baz')
...

but there are no tool .py files. For now, check_manifest() is okay with this since the exe's are defined, and I kept this the case in my implementation of #1091. However, not having the .py file would eventually lead to an exception in run().

Supposing that these exe's are actually set correctly, do you think we should consider this legal, or should we enforce that there is a .py file for each tool used in the flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant