This repository has been archived by the owner on Sep 14, 2018. It is now read-only.
Update code and Readme about included Providers #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the initial README.rst the `ValidatorServiceProvider` was missing, and there were already included providers like: `HttpFragmentServiceProvider` and `AssetServiceProvider` which where not specified in README.rst
jnadaud
reviewed
Nov 26, 2016
| @@ -5,12 +5,14 @@ | |||
| use Silex\Provider\TwigServiceProvider; | |||
| use Silex\Provider\ServiceControllerServiceProvider; | |||
| use Silex\Provider\HttpFragmentServiceProvider; | |||
| use Silex\Provider\ValidatorServiceProvider; | |||
There was a problem hiding this comment.
Hi @mhitza,
If not used in skeleton (not in tests), why add it ?
Maybe this would be more relevant in Silex docs, in order to detailed any possibilities ?
Kindly regards.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the initial README.rst the
ValidatorServiceProviderwasmissing, and there were already included providers like:
HttpFragmentServiceProviderandAssetServiceProviderwhichwhere not specified in README.rst