This repository has been archived by the owner on Sep 14, 2018. It is now read-only.
Make dev mode default #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whats the point of including the dev toolbar if it doesn't run without some contrived command... make it default!
jnadaud
reviewed
Nov 26, 2016
| @@ -34,7 +34,7 @@ | |||
| "scripts": { | |||
| "run": [ | |||
| "echo 'Started web server on http://localhost:8888'", | |||
| "php -S localhost:8888 -t web" | |||
| "php -S localhost:8888 -t web/index_dev.php" | |||
There was a problem hiding this comment.
Hi @rayfoss,
-t option is for serving document root directory, not php file.
Kindly regards
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats the point of including the dev toolbar if it doesn't run without some contrived command... make it default!
I even manually installed it, read the instructions and patched my controller with web profile code... that worked, but then I realized its also in the dev.php... a file that's not read by the default "composer run" command... perhaps maybe there should be a composer run-prod command as well. btw, running a docker image in a composer script works amazingly well... much better than trying to do the same in a node script.