Suppress RPC Error disconnect log

[dapplion]

Issue Addressed

Debugging das interop, noticed a noisy debug log:

May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.709 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489

This log is emitted from the peermanager, and is a consequence of allowing RPCError for disconnected peers through. If a peer disconnects and has 100 active ReqResp request, the log will appear 100 times.

Proposed Changes

If we allow to propagate the RPCError to the application, do not log it in the peer manager

[jimmygchen]

LGTM!

[jimmygchen]

LGTM. @AgeManning thoughts?

[michaelsproul]

Wrong Age 😅

@AgeManning

[ackintosh]

Looks good to me.

[realbigsean]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7073242