Verify inclusion proof should not be fallible #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
approved these changes
May 29, 2024
There was a problem hiding this comment.
Looks good! I think this is a low risk change if tested (as things would just blow up if this is doesn't work) and should be good to merge.
I wrote some tests here and they pass on your branch:
dapplion#33
jimmygchen
added
ready-for-merge
* Add blob sidecar inclusion test. * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Adding the verify inclusion proof function for data columns I noticed that
verify_blob_sidecar_inclusion_proofis fallible due to the need to do math with the EthSpec variables.Proposed Changes
Since the EthSpec values are non-configurable and properly chosen, it's not necessary to make
verify_blob_sidecar_inclusion_prooffallible. A unit test in EthSpec ensures that the values are correctly chosen and then we can safely expect.