Drop block data from BlockError and BlobError #5735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
BlockError::ParentUnknown
has a full RpcBlock are argument. This arrangement is:BlockError::ParentUnknown
is handled a block is already availableinto_rpc_block
which is a strange downgrade from types with strong meaning likeMaybeAvailableBlock::Available
Proposed Changes
into_rpc_block