Added support to disable suggestion selection #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a suggestion is disabled... - Set aria-disabled=true - Apply style - Don't handle onSelect Co-authored-by: Maks <sulimmaxim@gmail.com>
🦋 Changeset detectedLatest commit: 247672b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Sigrsig & @steffektif, sorry for the nudge - are you still maintaining this project? |
|
Hey sorry, already the last time you reached out I pinged some people. Currently @PreussHendrik and @crecotun are in charge. I hope they see this message and can help you out |
|
Thanks a lot @steffektif - appreciate it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've picked up #440 to try and get it merged.
This PR adds an optional
disabledprop to suggestions.If a suggestion is
disabled, it...aria-disabled = trueI've also...
If this lands, I'll make a separate PR to the DefinitelyTyped repo.
Feedback appreciated - cc @mastrix, @Sigrsig and @steffektif 🙏