Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match korean substring for suggestions #618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woosuk288
Copy link

Related #257 but only Korean.

#257 has been same problem in Korean as well but no one has seemed to fix this yet for quite a long. so I tried this.

- Before

before-react-metion_AdobeExpress


- After

after-react-metion_AdobeExpress


I think ch2pattern function could help pattern match from other languages if people know their language's regex pattern.



@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

🦋 Changeset detected

Latest commit: 76b5bdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-mentions ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:27PM (UTC)

Copy link

@oinochoe oinochoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function needs to be resolved beacuse i also have trouble in typing in korean.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix it, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants