Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix squashfuse issues #1445

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix squashfuse issues #1445

wants to merge 6 commits into from

Conversation

ErikParawell-SiFive
Copy link
Contributor

@ErikParawell-SiFive ErikParawell-SiFive commented Oct 18, 2023 •
edited

Fix issues caught by @V-FEXrt after #1439 was merged

Also built a test case for wakebox squashfuse. In doing so I discovered that I was not invoking squashfuse correctly so that is corrected now.
As a side note the test case sleeps for 3 seconds before it exits because it is possible that fuse is still unmounting when the rm -rf cleanup happens. Maybe wakebox needs a -o notify_pipe 馃槅

List of changes:

  • Added a test case to test squashfsfuse in wakebox.
  • Added bash to Alpine Dockerfile because I think that is a small requirement.
  • Updated the package lists in the README.md to include squashfuse related ones.
  • Addressed the post merge comments from Replace polling squashfuse聽#1439

JakeSiFive
JakeSiFive reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JakeSiFive JakeSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for this so that we don't hit this issue in the future.

A simple wakebox unit test that just runs cats a file out of a squash fuse mount would suffice

@ErikParawell-SiFive
Copy link
Contributor Author

ErikParawell-SiFive commented Oct 18, 2023 •
edited

I agree we should have a test case for this. I didn't realize we did not have one

@JakeSiFive
Copy link
Contributor

Me neither but the fact that this bug slipped passed CI indicates to me that it must be untested

@ErikParawell-SiFive ErikParawell-SiFive changed the title Address review concerns in squashfuse pr Fix squashfuse issues Oct 19, 2023
@ErikParawell-SiFive
Copy link
Contributor Author

Made a test case and update description:

Also built a test case for wakebox squashfuse. In doing so I discovered that I was not invoking squashfuse correctly so that is corrected now.
As a side note the test case sleeps for 3 seconds before it exits because it is possible that fuse is still unmounting when the rm -rf cleanup happens. Maybe wakebox needs a -o notify_pipe 馃槅

@ErikParawell-SiFive ErikParawell-SiFive force-pushed the erikp/fix-squashfuse-pr branch 2 times, most recently from 515af0a to 7f0e081 Compare October 19, 2023 02:31
@JakeSiFive
Copy link
Contributor

I'll take over this PR so it can land soon

@JakeSiFive
Copy link
Contributor

I'm going to wait to debug the rest of this. Issues like this are best debugged using a local podman/docker container but I've had serious issues getting docker to work correctly with namespacing since the kernel they use on the VM to run the containers on doesn't have things configured correctly. There is a way to use your own kernel on Mac docker but I'm lazy and would rather wait until I'm back home with my linux dev laptop that I can run podman on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V-FEXrt V-FEXrt V-FEXrt approved these changes

@JakeSiFive JakeSiFive JakeSiFive approved these changes

@mmjconolly mmjconolly Awaiting requested review from mmjconolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ErikParawell-SiFive @JakeSiFive @V-FEXrt