Fix wrong inline assembly code in nop_putc. #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in clang, the result is c.mv a1, a0 c.li a0, -1 c.mv a0, a1 slli zero, a0, 0x11 c.jr ra result is incorrect, we need to add a0 into clobber list.
zakk0610
requested review from
e-puerto,
paul-walmsley-sifive and
sifive-eblot
as code owners
kito-cheng
approved these changes
Aug 16, 2021
nick-knight
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Looks good to me.
FWIW, this is how @ericlove implemented this hack more than 15 months ago: 30fd755#diff-bc73b80291779f6c896ddcb3e37b2ed8567475c138048c14f5318e9771340fa3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add
a0into clobber list.In clang, the result is incorrect.
we could rewrite it and avoid additional
mvinstruction.