Add support for 64bit event selectors. New APIs. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NandkumarJoshi
requested review from
bsousi5,
nategraff-sifive and
BrianGraysonSiV
nategraff-sifive
suggested changes
Jul 14, 2020
There was a problem hiding this comment.
I agree with @BrianGraysonSiV that uintptr_t is the wrong type for these APIs.
BrianGraysonSiV
approved these changes
Jul 14, 2020
nategraff-sifive
approved these changes
Jul 14, 2020
New API to get supported no. of HPM counters. New API to assign user values to event selector register. Add metal_cpureg_t as a cpu register-size dependent type.
NandkumarJoshi
force-pushed
the
hpm-U8-fix
branch
from
d80d086
to
0427278
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 64bit event selectors for U8.
Add API to get supported no. of HPM counters.
Add API to assign user values to event selector register.
PR fix for changes requested by @BrianGraysonSiV