Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup wake code, inline autoconf_wrapper script #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup wake code, inline autoconf_wrapper script #203

wants to merge 1 commit into from

Conversation

albertchen-sifive
Copy link
Contributor

inline autoconf_wrapper so they don't get out of sync. also improve error reporting.

@albertchen-sifive
Copy link
Contributor Author

this will break compatibility with wake v0.15 which does not support multiline strings. though I think all repos that depend on this have moved on to v0.17?

richardxia
richardxia approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardxia richardxia richardxia approved these changes

@nategraff-sifive nategraff-sifive nategraff-sifive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertchen-sifive @richardxia @nategraff-sifive