feat: ✨ add flag to disable getSession after signIn on local / refresh provider #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bitfactory-oussama-fadlaoui
approved these changes
Mar 5, 2024
|
Hi @bitfactory-frank-spee , thanks for your contribution, it looks good to me. I will come back to it after #694 , so that we can ensure that it's functionally good. |
5 tasks
|
@bitfactory-frank-spee Could you please sync your PR with the current main? |
|
@phoenix-ru I will update it this week 👍 |
Done 🚀 |
zoey-kaiser
added
enhancement
zoey-kaiser
requested changes
May 22, 2024
| @@ -103,12 +105,16 @@ await signIn(credentials, { callbackUrl: '/protected' }) | |||
| // Trigger a sign-in with a redirect afterwards to an external page (if set, this will cause a hard refresh of the page) | |||
| await signIn(credentials, { callbackUrl: 'https://sidebase.io', external: true }) | |||
|
|
|||
| // Trigger a sign-in without calling getSession directly. You have to manually call it to get session data. | |||
| await signIn(credentials, { withGetSession: false }) | |||
There was a problem hiding this comment.
Can we rename this new option from withGetSession to just getSession? I think this would be a bit more readable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#701
❓ Type of change
📚 Description
See issue for clarification. This adds a flag to the signInOptions named
withGetSessionwhich defaults to true. This makes sure this will be backwards compatible. WhenwithGetSession === falsethegetSessionmethod will not be called.This also includes a bug fix (681fdb0) where refresh was not equal to local provider.
📝 Checklist