feat: Add refresh token to signOut request body #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
5 tasks
zoey-kaiser
added
enhancement
zoey-kaiser
approved these changes
May 10, 2024
There was a problem hiding this comment.
Hi @MisterNox 👋
Thank you so much for your contribution! As we are currently aiming for a larger 0.8 release, we will add your enchantment to that release.
@phoenix-ru, I think this PR is good to go, I would recommend that after your reviews we can merge this in the next batch and relase it in the next 0.8.0-alpha.2 release!
phoenix-ru
requested changes
May 14, 2024
| @@ -168,7 +172,7 @@ const signOut: SignOutFunc = async (signOutOptions) => { | |||
| | 'options' | |||
| | 'trace'; | |||
| } | |||
| res = await _fetch(nuxt, path, { method, headers }) | |||
| res = await _fetch(nuxt, path, { method, headers, body: method.toLowerCase() === 'post' ? body : undefined }) | |||
There was a problem hiding this comment.
May be better to build body only when the check is truthy:
const body = method.toLowerCase() === 'get'
? undefined
: objectFromJsonPointer(config.refreshToken.refreshRequestTokenPointer, refreshToken.value)
|
Hi @MisterNox 👋 Have you had a chance to look at the review yet? Otherwise are there any other open questions I can help you with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#730
❓ Type of change
📚 Description
Adds the refresh token to the signOut request body with the key set according to the defined
refreshRequestTokenPointer.📝 Checklist