Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token should be added to the signOut body #730

Open
2 of 5 tasks
MisterNox opened this issue Apr 8, 2024 · 0 comments · May be fixed by #731
Open
2 of 5 tasks

Refresh token should be added to the signOut body #730

MisterNox opened this issue Apr 8, 2024 · 0 comments · May be fixed by #731
Labels
enhancement An improvement that needs to be added p3 Minor issue

Comments

@MisterNox
Copy link

MisterNox commented Apr 8, 2024

Describe the feature

If you want to use the signOut method along with some server side token blacklists it is necessary to send the refresh token in the body of the http request. Right now no body is sent at all in the signOut method.

E.g. the django simple-jwt standard blacklist class requires the refresh token in the body.

How would you implement this?

This can be achieved in the same way as it is done in the refresh method. we can use the config.refreshToken.refreshRequestTokenPointer for the body key. To stay backwards compatible it might make sense to add the body only if we are doing a post request e.g. body: method === 'post' ? body : undefined (in case someone uses the signOut with a get request for some reason).

Additional information

  • Would you be willing to help implement this feature?

Provider

  • AuthJS
  • Local
  • Refresh
  • New Provider
@MisterNox MisterNox added enhancement An improvement that needs to be added pending labels Apr 8, 2024
@zoey-kaiser zoey-kaiser linked a pull request May 9, 2024 that will close this issue
9 tasks
@zoey-kaiser zoey-kaiser assigned phoenix-ru and unassigned phoenix-ru May 9, 2024
@zoey-kaiser zoey-kaiser added p3 Minor issue and removed pending labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement that needs to be added p3 Minor issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants