Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the URL query string parameter name used to specify the callback function name #416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2014

We are calling our API which allows querying on any field, as such we prepend control parameters with an underscore to avoid field name collisions, ie: _callback, _page_size, _page_num. This patch allows us to use Rickshaw as follows:

    var graph = new Rickshaw.Graph.JSONP({
        element: document.querySelector('#chart'),
        dataURL: "{% url 'api:dataset-data' dataset.namespace.slug dataset.slug %}",
        callbackParameter: "_callback",
   });

@cesine cesine self-assigned this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants