Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the li::marker color contrast in the theme blog's dark mode #2889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

87xie
Copy link

@87xie 87xie commented May 14, 2024

What

In the dark mode of the blog theme, the list item marker color still references the variables from the light mode, resulting in a lack of color contrast for the ordered list item markers.

I can create another pull request for the v3 branch if needed.

How

Referencing the current styles in the doc theme, apply the basic text color to the list item color in the blog theme.

Before

.nx-prose :where(ol>li):not(:where([class~=nx-not-prose] *))::marker {
    color: var(--tw-prose-counters); /* #6b7280 */
    font-weight: 400;
}

.nx-prose :where(ul>li):not(:where([class~=nx-not-prose] *))::marker {
    color: var(--tw-prose-bullets); /* #d1d5db */
}

image

After

:is(html[class~=dark] .dark\:nx-prose-dark) :where(li):not(:where([class~=nx-not-prose] *))::marker {
    color: #d1d5db;
}

image

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: ccf8418

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-blog Patch
nextra Patch
nextra-theme-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 1:18pm

Copy link

vercel bot commented May 14, 2024

@87xie is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant