Fixed shopware dependencies removing order, for command plugin:zip:vcs #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for Shopware6. (This bug led to crushing command for plugins which has not only shopware dependency)
mitelg
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, DependencyManager removing shopware packages in that order as the met in composer.json. That is why sometimes depending packages could be removed before the main one. That leads to the composer error in (
plugin:zip:vcs,plugin:zip:dir).Added private method
DependencyManager::getTheRightRemovingOrder()that provided the correct order of removing shopware packages. Currently, it means that package shopware/core would be removed last.