Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-36108 NewsletterSubscribe add salesChannelId filter #3699

Closed

Conversation

wexoag
Copy link
Contributor

@wexoag wexoag commented May 6, 2024

[NEXT-0000] Update getNewsletterRecipient to search for specific recipient from salesChannelId

1. Why is this change necessary?

Once a newsletter recipient exists on one salesChannel it possible that the wrong recipient is selected, and dispatched along with NewsletterConfirmEvent and NewsletterRegisterEvent in NewsletterSubscribeRoute

2. What does this change do, exactly?

Add salesChannelId filter to select newsletter recipient for the correct salesChannel

3. Describe each step to reproduce the issue or behaviour.

Add event listender for NewsletterConfirmEvent (dd) or something else to show salesChannelId.
Sign up for newsletter on one salesChannel then on another.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

[NEXT-0000] Update getNewsletterRecipient to search for specific recipient from salesChannelId
Copy link

github-actions bot commented May 6, 2024

Warnings
⚠️ The Pull Request doesn't contain any changelog file

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-36108

Please use this issue to track the state of your pull request.

@bschulzebaek bschulzebaek changed the title NEXT-0000 NewsletterSubscribe add salesChannelId filter NEXT-36108 NewsletterSubscribe add salesChannelId filter May 13, 2024
@bschulzebaek bschulzebaek self-assigned this May 13, 2024
@bschulzebaek
Copy link
Contributor

Hey @wexoag, thanks for your contribution! We've just merged it 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants