Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEXT-00000 - Add missing module warn message #3682

Closed
wants to merge 1 commit into from
Closed

NEXT-00000 - Add missing module warn message #3682

wants to merge 1 commit into from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 23, 2024 •
edited

1. Why is this change necessary?

  • When the media folder overview is loaded and a module for a media folder is missing, previously an error occurs (now there is no warn message) because it does not currently check whether the module exists before accessing it

2. What does this change do, exactly?

  • Changed sw-media-folder-item/index to check if the module exists, if not display a warn message for developers

3. Describe each step to reproduce the issue or behaviour.

  • Open the media folder overview with a missing module -> Previously: Error because the script is trying to access the manifest prop of the missing module, Now: No warn message from the missing module it just gets ignored

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@akf-bw akf-bw requested a review from shyim May 13, 2024 08:37
@akf-bw
Copy link
Contributor Author

akf-bw commented May 24, 2024 •
edited

@shyim It looks like the initial problem from this PR was fixed with d12d442#diff-7f512493902f72ede1d14ddbd7e4501ab1fff8b40782e3775bf4e7cbcf193ca7
Should this still get merged to display the warn message for developers?

@akf-bw akf-bw changed the title NEXT-00000 - Fix missing module error NEXT-00000 - Add missing module warn message May 24, 2024
@seggewiss
Copy link
Contributor

@shyim It looks like the initial problem from this PR was fixed with d12d442#diff-7f512493902f72ede1d14ddbd7e4501ab1fff8b40782e3775bf4e7cbcf193ca7 Should this still get merged to display the warn message for developers?

We can still merge this change. I'll take care.

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-36418

Please use this issue to track the state of your pull request.

@akf-bw akf-bw deleted the fix-missing-module-error branch May 27, 2024 07:46
@seggewiss
Copy link
Contributor

Thank you for contributing 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyim shyim Awaiting requested review from shyim

Assignees
No one assigned
Labels
Area: Administration Scheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akf-bw @seggewiss @shyim @OliverSkroblin