Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-35502 - Fix migration saleschannel test #3679

Closed

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 22, 2024

1. Why is this change necessary?

  • Run the Unit / PHPUnit for migration,migration-tests, sometimes the tests will fail at the testItDoesNotBreakIfNoHeadlessSalesChannelIsPresent function, because the sales channel can be blocked by other tests (e.g. order tests that refer to the saleschannel) running at the same time

2. What does this change do, exactly?

  • Changed Migration1620820321AddDefaultDomainForHeadlessSaleschannelTest to catch ForeignKeyConstraintViolationException

3. Describe each step to reproduce the issue or behaviour.

  • Run the Unit / PHPUnit for migration,migration-tests, sometimes the tests will fail at the testItDoesNotBreakIfNoHeadlessSalesChannelIsPresent function, because the sales channel can be blocked by other tests (e.g. order tests that refer to the saleschannel) running at the same time

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-35502

Please use this issue to track the state of your pull request.

@akf-bw akf-bw force-pushed the fix-migration-saleschannel-test branch from ed7306d to 1e4af8a Compare April 22, 2024 07:09
@akf-bw
Copy link
Contributor Author

akf-bw commented Apr 25, 2024

@OliverSkroblin Is there something holding this PR back from being merged?

@OliverSkroblin
Copy link
Member

@OliverSkroblin Is there something holding this PR back from being merged?

Not really, just internal pipelines which are failling right now. Nothing regarding your code change

@akf-bw akf-bw changed the title NEXT-00000 - Fix migration saleschannel test NEXT-35502 - Fix migration saleschannel test Apr 25, 2024
@akf-bw
Copy link
Contributor Author

akf-bw commented May 24, 2024

@OliverSkroblin It looks like recent pipeline changes that reorder test execution time unintentionally fixed the bug from the pipeline. However, just to be safe, it would be nice to merge this so we can be sure that the pipeline doesn't fail due to an invalid error.

@akf-bw akf-bw deleted the fix-migration-saleschannel-test branch May 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants