Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports to GoogleAnalytics BeginCheckoutEvent #3661

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Scarbous
Copy link
Contributor

implement supports function for BeginCheckoutEvent like ViewItemListEvent

1. Why is this change necessary?

  • Prevent errors, when the "begin-checkout-btn" gets removed from the CartOverlay.

2. What does this change do, exactly?

  • Only trigger the event if the "begin-checkout-btn" exists

3. Describe each step to reproduce the issue or behaviour.

  • Remove "begin-checkout-btn" from CarOverlay template
  • Add Item to cart
  • Open Cart Overlay
  • Marvel at the exception 🙃

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

implement supports function for BeginCheckoutEvent like ViewItemListEvent
Copy link

Warnings
⚠️ The Pull Request doesn't contain any changelog file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage required Work in progress Proposal is work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants