Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify generated open api structure and manual overrides #871

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Apr 15, 2024

Description

Draft of incoming generator changes. More detailed description will show up here soon.

Type of change

For canary - breaking but simplifying, migration path will be provided.
For stable - breaking but more simple than current stable->canary transition.

ToDo's

  • test and generate query params
  • test and generate path params
  • test and generate headers
  • (optional) override only part of schema/operation
  • rewrite RequestParameters and RequestReturnType
  • migrate creating admin client
  • ...

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ❌ Failed (Inspect) May 13, 2024 8:00am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview May 13, 2024 8:00am

Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #871 will degrade performances by 95.33%

Comparing feat/api-client-new-structure (fbb97c3) with main (823aa9b)

Summary

❌ 2 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/api-client-new-structure Change
[api-client][transformPathToQuery] - transform without any params 294.4 µs 6,299.2 µs -95.33%
[api-gen][generate] - generate schema command 2.1 s 28.7 s -92.74%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant