Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add custom element page #840

Merged
merged 10 commits into from May 6, 2024
Merged

docs: add custom element page #840

merged 10 commits into from May 6, 2024

Conversation

mdanilowicz
Copy link
Collaborator

Description

closes #505

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Apr 26, 2024 8:17am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Apr 26, 2024 8:17am

Copy link

codspeed-hq bot commented Apr 3, 2024

CodSpeed Performance Report

Merging #840 will not alter performance

Comparing feat/GH-505 (1f125e8) with main (18d8528)

Summary

✅ 9 untouched benchmarks

@BrocksiNet
Copy link
Collaborator

The main idea of that issue was to have a step by step guide from admin/backend to frontends component. If I would have no idea about admin/frontends this new page would not be helpful to me. I would ask myself what is the key fact I am learning here on this page and what is the difference to "Overwritting CMS" Page. Also there is no link to admin docs about how to create a CMS Element.

@mdanilowicz mdanilowicz marked this pull request as draft April 4, 2024 07:24
@mdanilowicz
Copy link
Collaborator Author

The main idea of that issue was to have a step by step guide from admin/backend to frontends component. If I would have no idea about admin/frontends this new page would not be helpful to me. I would ask myself what is the key fact I am learning here on this page and what is the difference to "Overwritting CMS" Page. Also there is no link to admin docs about how to create a CMS Element.

ok, got it I'll change it

@BrocksiNet
Copy link
Collaborator

Custom Element is missing in main CMS Page in Docs.

@patzick patzick merged commit 823aa9b into main May 6, 2024
12 checks passed
@patzick patzick deleted the feat/GH-505 branch May 6, 2024 13:01
BrocksiNet pushed a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Custom CMS Elements and how to use them
4 participants