Convert pythonic imports for all python/graphical #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this! We actually do not run CI jobs on these examples (these are usually quite low priority when refactoring and are probably mostly outdated). |
|
Figures, I see why everything's still in Python 2. Thanks for merging anyway, new to PRs and learned a lot from it. Will look around for other spots where I can help cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combed through and updated the python/graphical folder; partially addresses #4990 and fixed some minor typos/print statements. Seems like we're mostly doing Python2 prints (i.e. no parenthesis), so went ahead and standardized that.