Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonic imports of shogun #4990

Open
karlnapf opened this issue Apr 2, 2020 · 6 comments
Open

pythonic imports of shogun #4990

karlnapf opened this issue Apr 2, 2020 · 6 comments

Comments

@karlnapf
Copy link
Member

karlnapf commented Apr 2, 2020

We want to replace imports in the lines of

  • from shogun import *
  • from shogun import features

with import shogun as sg, and then call shogun methods with that handle, i.e. sg.features instead of just features

This is as the number of names of shogun API objects that clash with potential variable names (features) is growing and we want to avoid confusion.

This needs to be done in (in order of priority)

  • meta examples (see examples/meta/generator/targets/python.json)
  • notebooks
  • all other python code in the repo
@Ahmetelsemeli
Copy link

@vigsterkr

@mohitmajithia
Copy link

which files are left?

@karlnapf
Copy link
Member Author

karlnapf commented May 4, 2020

please find out yoursef. that is part of the task

mohitmajithia added a commit to mohitmajithia/shogun that referenced this issue May 4, 2020
made changes in this file shogun-toolbox#4990
mohitmajithia added a commit to mohitmajithia/shogun that referenced this issue May 4, 2020
@ritikavar
Copy link

i am beginner how can i solve my first issue

@HarshBamotra
Copy link

Hello, I tried solving this issue in some of the files which I have found but I don't know why it is not passing the checks in my pull request #5156. Can you help me with that why it is happening?

@arya2910
Copy link

arya2910 commented Mar 5, 2021

can i work on this issue??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants